feat: hide new public funcs introduced by linearization #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 79.54% 79.59% +0.05%
==========================================
Files 158 158
Lines 20440 20509 +69
Branches 19474 19542 +68
==========================================
+ Hits 16258 16324 +66
- Misses 3201 3203 +2
- Partials 981 982 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aborgna-q
approved these changes
Dec 29, 2025
Collaborator
aborgna-q
left a comment
aborgna-q
left a comment
There was a problem hiding this comment.
Nice!
Could we do a test counting expected public functions or something similar?
aborgna-q
force-pushed
the
ab/bump-hugr-0.25
branch
3 times, most recently
from
3b4efbe to
c7a2221
Compare
acl-cqc
force-pushed
the
acl/hide_funcs
branch
from
9a6c975 to
db104dd
Compare
Contributor
Author
|
Test revealed (and is pending) fix in Quantinuum/hugr#2792 ....EDIT so using a simpler test here |
acl-cqc
force-pushed
the
acl/hide_funcs
branch
from
09bd532 to
e0eb985
Compare
acl-cqc
changed the title
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So following #1325 I was finally able to (/finally succeeded) in evaluating the effect of Quantinuum/hugr#2749 on guppy tests. (There was some question on that PR as to whether we needed to add new facility, see #2766; here is the data.)
Three tests were affected (indeed the same ones as were broken and then fixed by Quantinuum/hugr#2779 but that is a separate issue). The sizes of the LLVM output as follows:
Inspection of the hugrs in the middle row revealed the helper functions from Quantinuum/hugr#2749 were indeed present in the LLVM output as
define(notdefine private). Hence, this PR, following which LLVM is able to remove thedefines. (I have not looked into the remaining +2-3% increase. (The numbers include many other changes between hugr-0.24.3 and hugr-0.25.0.)